Update WebClient references to HttpClient in F# asynchronous programming documentation #43794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shethaadit
requested review from
a team,
BillWagner and
KathleenDollard
as code owners
dotnet-policy-service
bot
added
okr-quality
psfinaki
approved these changes
Nov 28, 2024
Contributor
psfinaki
left a comment
psfinaki
left a comment
There was a problem hiding this comment.
Thanks Adit for updating F# docs :)
vzarytovskii
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses outdated references to
WebClientin the F# asynchronous programming documentation. The sample code was updated in PR #43626 to useHttpClientwithGetStringAsync, but the accompanying text still mentionsWebClient.AsyncDownloadString.Changes include:
WebClient.AsyncDownloadStringwithHttpClient.GetStringAsync(wrapped withAsync.AwaitTaskfor F# compatibility).HttpClient.These updates ensure consistency between the code sample and the explanatory text, improving the clarity and accuracy of the documentation.
Fixes #43744
Internal previews