Skip to content

Add docs for SYSLIB5003 #43288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 12, 2024
Merged

Add docs for SYSLIB5003 #43288

merged 11 commits into from
Nov 12, 2024
+29 −1

Conversation

@kunalspathak
Copy link
Contributor

@kunalspathak kunalspathak commented Nov 1, 2024 •
edited by github-actions bot
Loading

@kunalspathak kunalspathak requested a review from a team as a code owner November 1, 2024 21:04
@dotnetrepoman dotnetrepoman bot added this to the November 2024 milestone Nov 1, 2024
@kunalspathak kunalspathak mentioned this pull request Nov 1, 2024
Open
jeffhandley
jeffhandley reviewed Nov 1, 2024
View reviewed changes
gewarren
gewarren reviewed Nov 1, 2024
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also add a link from the experimental-overview.md file?

@kunalspathak
Copy link
Contributor Author

kunalspathak commented Nov 1, 2024

Shouldn't we also add a link from the experimental-overview.md file?

https://github.com/dotnet/docs/blob/main/docs/fundamentals/syslib-diagnostics/experimental-overview.md already has a reference, unless you want me to add something more.

jeffhandley
jeffhandley approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 changes left for reverting files that didn't need updates, but then approved.

Thank you!

@jeffhandley
Copy link
Member

jeffhandley commented Nov 4, 2024

Shouldn't we also add a link from the experimental-overview.md file?

https://github.com/dotnet/docs/blob/main/docs/fundamentals/syslib-diagnostics/experimental-overview.md already has a reference, unless you want me to add something more.

I overlooked this. The experimental-overview page should link to this one per @gewarren's suggestion. The table's first cell that has the diagnostic ID can just become a link to this page; that should be sufficient.

@kunalspathak
Copy link
Contributor Author

kunalspathak commented Nov 8, 2024

done

gewarren
gewarren approved these changes Nov 8, 2024
View reviewed changes
@gewarren gewarren enabled auto-merge (squash) November 8, 2024 23:00
@gewarren gewarren merged commit b097bb5 into dotnet:main Nov 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffhandley jeffhandley jeffhandley approved these changes

@gewarren gewarren gewarren approved these changes

Assignees

No one assigned

Labels

dotnet-fundamentals/svc

Projects

None yet

Milestone

November 2024

Development

Successfully merging this pull request may close these issues.

3 participants

@kunalspathak @jeffhandley @gewarren