Skip to content

Conversation

@BartoszKlonowski
Copy link
Contributor

This pull request closes #41927
It completely removes the Publish events that conform to .NET Guidelines article and sets a redirection to the overview article in the standard for the events.

@BartoszKlonowski BartoszKlonowski requested review from a team and BillWagner as code owners August 6, 2024 20:52
@dotnet-bot dotnet-bot added this to the August 2024 milestone Aug 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Aug 6, 2024
@BillWagner
Copy link
Member

Hi @BartoszKlonowski

Can you remove the article from the TOC as well? See https://github.com/dotnet/docs/blob/main/docs/csharp/toc.yml#L649-L650

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @BartoszKlonowski

This LGTM. Let's :shipit:

@BillWagner BillWagner enabled auto-merge (squash) August 13, 2024 14:18
@BillWagner BillWagner disabled auto-merge August 13, 2024 14:21
@BillWagner BillWagner merged commit 109608e into dotnet:main Aug 13, 2024
@BillWagner
Copy link
Member

I went ahead and merged this. I'll do a fast follow using our tools to fixup the links to the removed article.

@BartoszKlonowski If you're interested, the cleanrepo tool in our docs-tools repo is how we fix those up.

@BartoszKlonowski
Copy link
Contributor Author

@BillWagner Oh, that looks super useful, good to know about!
And sorry for all this back and forth with this one 🙏

BillWagner added a commit to BillWagner/docs that referenced this pull request Aug 13, 2024
Fix redirects that caused warnings.
BillWagner added a commit that referenced this pull request Aug 13, 2024
Fix redirects that caused warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc fundamentals/subsvc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicated content

3 participants