Skip to content

Fix or add more details about some MSTest rules #41885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 26, 2024
Merged

Fix or add more details about some MSTest rules #41885

merged 3 commits into from
Jul 26, 2024

Conversation

@Evangelink
Copy link
Member

@Evangelink Evangelink commented Jul 24, 2024 •
edited by github-actions bot
Loading

Internal previews

📄 File 🔗 Preview link
docs/core/testing/mstest-analyzers/mstest0008.md MSTEST0008: TestInitialize method should have valid layout
docs/core/testing/mstest-analyzers/mstest0009.md "MSTEST0009: TestCleanup method should have valid layout"
docs/core/testing/mstest-analyzers/mstest0010.md MSTEST0010: ClassInitialize method should have valid layout
docs/core/testing/mstest-analyzers/mstest0011.md docs/core/testing/mstest-analyzers/mstest0011
docs/core/testing/mstest-analyzers/mstest0012.md MSTEST0012: AssemblyInitialize method should have valid layout
docs/core/testing/mstest-analyzers/mstest0013.md "MSTEST0013: AssemblyCleanup method should have valid layout"
docs/core/testing/mstest-analyzers/mstest0029.md MSTEST0029: Public method should be test method
docs/core/testing/mstest-analyzers/mstest0030.md MSTEST0030: Type containing [TestMethod] should be marked with [TestClass]

@Evangelink Evangelink requested a review from IEvangelist as a code owner July 24, 2024 12:35
@dotnet-bot dotnet-bot added this to the July 2024 milestone Jul 24, 2024
@Evangelink
Copy link
Member Author

Evangelink commented Jul 25, 2024

Ready for review @IEvangelist

IEvangelist
IEvangelist reviewed Jul 25, 2024
View reviewed changes
@Evangelink Evangelink enabled auto-merge (squash) July 26, 2024 10:27
@Evangelink Evangelink requested a review from IEvangelist July 26, 2024 10:27
@Evangelink Evangelink merged commit 2fbe181 into dotnet:main Jul 26, 2024
@Evangelink Evangelink deleted the mstest-analyzers branch July 26, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

Assignees

No one assigned

Labels

dotnet-fundamentals/svc

Projects

None yet

Milestone

July 2024

Development

Successfully merging this pull request may close these issues.

3 participants

@Evangelink @IEvangelist @dotnet-bot