Skip to content

Conversation

@vernou
Copy link
Contributor

@vernou vernou commented Jul 18, 2024

Summary

  • Modify a example to the async main await the main taks.
  • Fix a example to run the example program

Fixes #40757 (and its duplicate dotnet/command-line-api#2427)


Internal previews

📄 File 🔗 Preview link
docs/standard/commandline/get-started-tutorial.md Tutorial: Get started with System.CommandLine

@vernou vernou requested a review from tdykstra as a code owner July 18, 2024 11:46
@dotnet-bot dotnet-bot added this to the July 2024 milestone Jul 18, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Jul 18, 2024
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a suggestion for a clarification.

Co-authored-by: Tom Dykstra <[email protected]>
@vernou
Copy link
Contributor Author

vernou commented Jul 26, 2024

@tdykstra, what is the next step?

@tdykstra tdykstra merged commit e222d75 into dotnet:main Jul 26, 2024
@tdykstra
Copy link
Contributor

@tdykstra, what is the next step?

The next step was for me to merge it, which I just now did. Thanks for contributing this.

@vernou
Copy link
Contributor Author

vernou commented Jul 26, 2024

Ok, you are welcome.

@vernou vernou deleted the 40757-fix-example branch July 26, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix dotnet run example in System.CommandLine tutorial

3 participants