Skip to content

Conversation

@IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Jun 26, 2024

Noticed while watching @shanselman's talk from NDC Australia that the trimming docs had the incorrect language identifier. He also used my code, yay!

https://youtu.be/KqhhaMgbGhU?t=590

image

https://learn.microsoft.com/en-us/dotnet/core/docker/build-container?tabs=windows&pivots=dotnet-8-0#create-net-app


Internal previews

📄 File 🔗 Preview link
docs/core/deploying/trimming/trimming-options.md Trimming options

Noticed while watching @shanselman's talk from NDC Australia that the trimming docs had the incorrect language identifier. He also used my code, yay!
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I'll :shipit: now.

@BillWagner BillWagner merged commit d0ff579 into main Jul 1, 2024
@BillWagner BillWagner deleted the correct-tags branch July 1, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants