Skip to content

Conversation

@jtschuster
Copy link
Member

@jtschuster jtschuster commented May 7, 2024

Summary

While going through warnings I saw that this page only describes the trivial case but misses the more confusing case of annotations triggering the warning. I think it would be nice to add a bit more info about it.


Internal previews

📄 File 🔗 Preview link
docs/core/deploying/trimming/trim-warnings/il2111.md IL2111: Method with parameters or return value with 'DynamicallyAccessedMembersAttribute' is accessed via reflection. Trimmer cannot guarantee availability of the requirements of the method

jtschuster added 3 commits May 7, 2024 10:47
Document confusing example of IL2111 warning.
@jtschuster jtschuster requested review from agocke and sbomer May 7, 2024 17:52
@jtschuster jtschuster requested a review from adegeo as a code owner May 7, 2024 17:53
@dotnet-bot dotnet-bot added this to the May 2024 milestone May 7, 2024
@jtschuster jtschuster changed the title Add more common and more confusing example for IL2111 Add example for the more common and confusing IL2111 cases May 7, 2024
@BillWagner
Copy link
Member

ping @adegeo for review

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@BillWagner BillWagner modified the milestones: May 2024, June 2024 Jun 7, 2024
@BillWagner BillWagner merged commit a4fc471 into main Jul 1, 2024
@BillWagner BillWagner deleted the jtschuster-patch-1 branch July 1, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants