Add description and initial guidance for DOTNET_HOST_PATH usage #36383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
reviewed
Jul 25, 2023
eerhardt
reviewed
Jul 25, 2023
marcpopMSFT
reviewed
Jul 25, 2023
marcpopMSFT
reviewed
Jul 25, 2023
vitek-karas
reviewed
Jul 25, 2023
|
jaredpar
approved these changes
Jul 25, 2023
@baronfel in the test repo we have the alg to find out correct dotnet muxer per architecture and per OS, using env vars(DOTNET_ROOT*), installation location(specific installation location for Windows/Mac) and default installation path https://github.com/microsoft/vstest/blob/main/src/Microsoft.TestPlatform.CoreUtilities/Helpers/DotnetHostHelper.cs#L121 |
richlander
reviewed
Jul 31, 2023
clarify that this impacts subprocesses only, and is very focused on the .NET SDK, not a general mechanism
eerhardt
reviewed
Aug 3, 2023
Co-authored-by: Eric Erhardt <[email protected]>
eerhardt
approved these changes
Aug 3, 2023
vitek-karas
approved these changes
Aug 3, 2023
jaredpar
approved these changes
Aug 3, 2023
richlander
reviewed
Aug 3, 2023
richlander
reviewed
Aug 3, 2023
richlander
reviewed
Aug 3, 2023
Co-authored-by: Rich Lander <[email protected]>
Co-authored-by: Rich Lander <[email protected]>
richlander
approved these changes
Aug 3, 2023
tdykstra
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on conversations in dotnet/runtime#88754, dotnet/roslyn#69186, and other places, we need documentation about this environment variable and its purpose. This is a draft of that documentation - though we may also need a dedicated page for "How should I locate the correct
dotnetbinary?" for application developers.Internal previews