-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Update cli-templates-create-template-package.md #35985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cli-templates-create-template-package.md #35985
Conversation
fix linter errors
vlada-shubina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we add a couple of paragraphs describing:
- MSBuild tasks with reference to: https://github.com/dotnet/templating/tree/main/tools
- localization (included in template pack) with reference to: https://github.com/dotnet/templating/blob/main/docs/authoring-tools/Localization.md
and briefly describe how to disable all tasks, or localization only.
|
@tdykstra could you please review and advise whether we can make this article available now or after .NET 8? The PR streamlines this tutorial, by using additional package templating team provides, however it is not part of .NET SDK. @baronfel fyi |
b547d3e to
edd6153
Compare
edd6153 to
e4cdf11
Compare
tdykstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, aside from some minor notes and suggestions.
We would have to keep the .NET 7 version available. We can do that by using zone pivots. Specifically, dotnet-preview-version zone pivot ID in zone-pivot-groups.yml gives you a choice between .NET 6, 7, and 8. You could have one block for both 6 and 7, and one for 8. For an example that shows 6 and 7 as choices, see https://github.com/dotnet/docs/blob/main/docs/core/tutorials/with-visual-studio.md The contributor guide article is here. Or if you prefer, I can add the .NET 7 version after this PR is ready to merge. |
Co-authored-by: Tom Dykstra <[email protected]>
5c5b6c8 to
cfa877f
Compare
cfa877f to
e757ee1
Compare
That is a great feature! I applied it to the article, here are some concerns:
In general, .NET 8 way may be used also with earlier version of SDK - the template suggested to be used is compatible with previous versions, but not sure to which extend, like EOL versions like .NET 5 won't work well. Do you think it is worth to put the note about it? |
|
@tdykstra the warning in the build seems unrelated, can it be rerun somehow? |
dde7d66 to
35b2dc6
Compare
The unrelated warning will be fixed in ~15 minutes and we can then close-reopen the PR to get a clean build. I fixed the build suggestion that was related. |
I think it's good as-is for now. At 8 GA we'll change the pivot group to eliminate "Preview", and when 6 goes out of support we'll update the pivot group or create a new one with only 7 and 8. |
tdykstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved when one outstanding suggestion is addressed.
|
Closing and reopening to trigger build. |
I missed addressing this -- Yes I think a note explaining that the .NET 8 way is compatible with earlier in-support versions (or just specify 6 and 7) would be helpful. |
just noticed that project file in the template has |
Summary
The Template Engine team has introduced a special template for simplifying the packaging process.
The changes describe how to work with it.
partially fixes dotnet/templating#5507
Internal previews