Update breaking-changes.md #34544
Merged
Update breaking-changes.md #34544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed "almost any change in behavior could result breaking someone" to be "almost any change in behavior could cause a logic error for a consumer". I very much doubt the author intended to say "breaking someone", maybe "breaking something" and that's why I added 'for a consumer'. Personally I prefer "almost any change in behavior could cause a logic error" but will leave it changed as-is to keep as close to what I believe is the authors intent.
Contributor
Author
|
@dotnet-policy-service agree |
ghost
added
the
community-contribution
IEvangelist
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed "almost any change in behavior could result breaking someone" to be "almost any change in behavior could cause a logic error for a consumer".
Summary
I think the author intended to convey the idea that a change to behavior in a library can cause breaking changes for the consumer of that library, that's why they wrote 'breaking someone'. However, that doesn't read well nor convey the idea well. It reads as though the 'someone' is the thing that is breaking, not their code. I prefer the change to read "almost any change in behavior could cause a logic error", leaving off the 'for a consumer', but will leave that on the change to keep it as close to what I believe was the authors intent.
Fixes #Issue_Number (if available)
Internal previews