Skip to content

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Sep 22, 2021

@gewarren gewarren requested a review from a team as a code owner September 22, 2021 21:51
@gewarren gewarren requested a review from layomia September 22, 2021 21:58
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@layomia layomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks


## Previous behavior

Projects that were compiled using the .NET 6 RC 1 or earlier version of the System.Text.Jason (STJ) source generator and library run as expected.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Projects that were compiled using the .NET 6 RC 1 or earlier version of the System.Text.Jason (STJ) source generator and library run as expected.
Projects that were compiled using the .NET 6 RC 1 or earlier version of the System.Text.Json source generator and library run as expected.

@gewarren gewarren merged commit abf4d3a into dotnet:main Sep 23, 2021
@gewarren gewarren deleted the json-source-gen branch September 23, 2021 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Breaking change]: JSON source-gen API refactoring causes binary-compat breaking change

4 participants