Skip to content

Conversation

@davidglassborow
Copy link
Contributor

Document --deterministic fsharp compiler option

Summary

This documents the compiler option added in dotnet/fsharp#2954.

Details

See PR for full details of what was done.

Suggested Reviewers

@cartermp

@dnfclas
Copy link

dnfclas commented Jun 21, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@svick
Copy link
Contributor

svick commented Jun 21, 2017

Since the PR was merged recently, is this option present in the latest released version of fsc? I think the docs should be about the latest released version, not about what's in master.

@davidglassborow
Copy link
Contributor Author

@svick I'm not exactly sure when it will be in the released fsc, @cartermp manages the F# team at MS so I'll let him advise.

@cartermp
Copy link
Contributor

This feature will be merged into VS 2017 Update 3, which will land in a few months. I'm fine with blocking on merging until that time frame, so long as this is tagged appropriately. We do weekly triage and we'll catch it then. Sound good @davidglassborow?

@davidglassborow
Copy link
Contributor Author

Sounds fine @cartermp, just give me a shout if you need the wording changed.

@mairaw mairaw added blocked Blocked for some reason WIP labels Jun 26, 2017
@mairaw
Copy link
Contributor

mairaw commented Aug 12, 2017

@cartermp I know this is blocked, but do you approve this PR or do we need to change anything? Just wanted to check whether this is ready to go, once it's go-time.

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go for me. We'll merge this once 15.3 ships.

@mairaw mairaw removed the blocked Blocked for some reason label Aug 14, 2017
@mairaw
Copy link
Contributor

mairaw commented Aug 14, 2017

Removing blocked label and merging this. Thanks @davidglassborow!

@mairaw mairaw merged commit 2cbac8b into dotnet:master Aug 14, 2017
@mairaw mairaw removed the WIP label Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants