Skip to content

Quoted number deserialization breaking change #21135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2020
Merged

Quoted number deserialization breaking change #21135

merged 2 commits into from
Oct 20, 2020

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 16, 2020 •
edited
Loading

@gewarren gewarren requested a review from a team as a code owner October 16, 2020 23:01
@dotnet-bot dotnet-bot added this to the October 2020 milestone Oct 16, 2020
@gewarren gewarren requested review from layomia and tdykstra October 16, 2020 23:13
tdykstra
tdykstra approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gewarren gewarren merged commit f75abc2 into dotnet:master Oct 20, 2020
@gewarren gewarren deleted the json-web branch October 20, 2020 17:32
layomia
layomia reviewed Oct 20, 2020
View reviewed changes
Copy link
Contributor

@layomia layomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gewarren gewarren mentioned this pull request Oct 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdykstra tdykstra tdykstra approved these changes

+2 more reviewers

@ahsonkhan ahsonkhan ahsonkhan left review comments

@layomia layomia layomia left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

October 2020

Development

Successfully merging this pull request may close these issues.

Breaking change: New JsonSerializerDefaults.Web option leveraged by ASP.NET allows quoted numbers when deserializing JSON

6 participants

@gewarren @tdykstra @ahsonkhan @layomia @BillWagner @dotnet-bot