Skip to content

Add reference assemblies topic #14393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Oct 17, 2019
Merged

Add reference assemblies topic #14393

merged 21 commits into from
Oct 17, 2019

Conversation

@MSDN-WhiteKnight
Copy link
Contributor

@MSDN-WhiteKnight MSDN-WhiteKnight commented Sep 12, 2019

Summary

Adds conceptual documentation about reference assemblies.

Sources:

Fixes #14281
Fixes #2638

//cc @rpetrusha @svick @terrajobst @jcouv

@rpetrusha rpetrusha added this to the September 2019 milestone Sep 12, 2019
@rpetrusha
Copy link
Contributor

rpetrusha commented Sep 12, 2019

@terrajobst, could you review this new article, please?

@terrajobst terrajobst self-requested a review September 12, 2019 18:42
rpetrusha
rpetrusha previously requested changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for writing this topic, @MSDN-WhiteKnight. We really appreciate your contribution. I've left some comments for you to address, as well as some suggestions for you to consider.

@rpetrusha
Copy link
Contributor

rpetrusha commented Oct 3, 2019

@terrajobst, could you take a look at this new article when you get a chance, please?

terrajobst
terrajobst approved these changes Oct 5, 2019
View reviewed changes
@terrajobst terrajobst requested a review from jaredpar October 5, 2019 00:59
Youssef1313
Youssef1313 requested changes Oct 5, 2019
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a missing period

dsplaisted
dsplaisted reviewed Oct 7, 2019
View reviewed changes
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rewrite a lot of the section about Using reference assemblies. Developers should normally never need to worry about the actual paths to the reference assemblies, that's all handled by .NET and .NET Core's MSBuild logic.

@MSDN-WhiteKnight
Copy link
Contributor Author

MSDN-WhiteKnight commented Oct 10, 2019

I've addressed requested changes. Please re-review.

dsplaisted
dsplaisted reviewed Oct 14, 2019
View reviewed changes
@Thraka
Copy link
Contributor

Thraka commented Oct 16, 2019

Close/repen to rerun new checks.

@Thraka Thraka closed this Oct 16, 2019
@Thraka Thraka reopened this Oct 16, 2019
@Thraka
Copy link
Contributor

Thraka commented Oct 16, 2019

Only two more conversations required to be resolved, then we can gets sign-off and then ship!

@Thraka Thraka dismissed rpetrusha’s stale review October 16, 2019 18:05

rpetrusha is not available

@Thraka
Copy link
Contributor

Thraka commented Oct 17, 2019

Awesome job!

@Thraka Thraka merged commit c1ed33f into dotnet:master Oct 17, 2019
@MSDN-WhiteKnight MSDN-WhiteKnight deleted the refas branch October 20, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsplaisted dsplaisted dsplaisted left review comments

@Youssef1313 Youssef1313 Youssef1313 requested changes

@jaredpar jaredpar Awaiting requested review from jaredpar

@rpetrusha rpetrusha Awaiting requested review from rpetrusha

+2 more reviewers

@Thraka Thraka Thraka approved these changes

@terrajobst terrajobst terrajobst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MSDN-WhiteKnight MSDN-WhiteKnight

Labels

None yet

Projects

None yet

Milestone

September 2019

Development

Successfully merging this pull request may close these issues.

New topic proposal: Reference assemblies What are reference assemblies?

8 participants

@MSDN-WhiteKnight @rpetrusha @Thraka @dsplaisted @jaredpar @terrajobst @Youssef1313 @dotnet-bot