Skip to content

[Breaking change]: changed parameter name in HtmlElement.InsertAdjacentElement from orient to orientation #42558

@Tanya-Solyanik

Description

@Tanya-Solyanik

Description

Renamed parameter in HtmlElement.InsertAdjacentElement from orient to orientation to avoid PoliCheck errors and because the later is a more descriptive name and a noun.

Version

.NET 10 Preview 1

Previous behavior

No API behavior changes, but the callsites might have to be updated. Previously the user would write:

element.InsertAdjacentElement(orient: HtmlElementInsertionOrientation.AfterEnd, newElement);

New behavior

Call sites should be edited to have the new parameter name or parameter name should be removed

element.InsertAdjacentElement(orientation: HtmlElementInsertionOrientation.AfterEnd, newElement);
element.InsertAdjacentElement(HtmlElementInsertionOrientation.AfterEnd, newElement);

Type of breaking change

  • Binary incompatible: Existing binaries might encounter a breaking change in behavior, such as failure to load or execute, and if so, require recompilation.
  • Source incompatible: When recompiled using the new SDK or component or to target the new runtime, existing source code might require source changes to compile successfully.
  • Behavioral change: Existing binaries might behave differently at run time.

Reason for change

PoliCheck errors https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2240374

Recommended action

Call sites should be edited to have the new parameter name or parameter name should be removed

element.InsertAdjacentElement(orientation: HtmlElementInsertionOrientation.AfterEnd, newElement);
element.InsertAdjacentElement(HtmlElementInsertionOrientation.AfterEnd, newElement);

Feature area

Windows Forms

Affected APIs

https://learn.microsoft.com/en-us/dotnet/api/system.windows.forms.htmlelement.insertadjacentelement?view=windowsdesktop-8.0


Associated WorkItem - 360643

Metadata

Metadata

Assignees

Labels

🏁 Release: .NET 10Work items for the .NET 10 release📌 seQUESTeredIdentifies that an issue has been imported into Quest.breaking-changeIndicates a .NET Core breaking changein-prThis issue will be closed (fixed) by an active pull request.source incompatibleSource code may encounter a breaking change in behavior when targeting the new version.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions