[essentials] Clean up include files #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbritch
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
Thanks @adegeo
I've (hopefully) answered your TODOs inline.
| --- | ||
|
|
||
| When requesting a share or opening launcher on iPadOS you have the ability to present in a pop over control. This specifies where the pop over will appear and point an arrow directly to. This location is often the control that launched the action. You can specify the location using the `PresentationSourceBounds` property: | ||
| When requesting a share or opening launcher on iPadOS, you can present in a popover. This specifies where the pop over will appear and point an arrow directly to. This location is often the control that launched the action. You can specify the location using the `PresentationSourceBounds` property: |
There was a problem hiding this comment.
Noticed that the first sentence says popover, while the second says pop over.
|
|
||
| This can then be used when calling `RequstAsync`: | ||
|
|
||
| <!-- TODO: I don't think this code works. I can't resolve Share.RequestAsync and there is a type mismatch on bounds.ToSystemRectangle and what is Analytics for? Is that normal to put in these examples? odd --> |
There was a problem hiding this comment.
- Remove the
Analytics.TrackEventline. That's a telemetry call into AppCenter that's irrelevant to this doc. - Share.RequestAsync should resolve against https://github.com/dotnet/maui/blob/main/src/Essentials/src/Share/Share.shared.cs
element.GetAbsoluteBoundswould resolve in a full sample - it's in the ViewHelpers class (https://github.com/dotnet/maui/blob/main/src/Essentials/samples/Samples/Helpers/ViewHelpers.cs) - also above (namespace unspecified) in this include file. See https://github.com/dotnet/maui/blob/main/src/Essentials/samples/Samples/ViewModel/ShareViewModel.cs for an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
@davidbritch
Review Commit 1
Review Commit 2