[essentials] First two articles ported #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbritch
suggested changes
Aug 4, 2021
Contributor
davidbritch
left a comment
davidbritch
left a comment
There was a problem hiding this comment.
Thanks for this @adegeo
I suggest three general changes:
- For the title metadata, and the page title, I'd recommend going with ".NET MAUI Essentials: ". We've had plenty of user feedback in the past that when they come into a page from a search engine, they want to know exactly what product the page is for.
- Afraid you'll have to drop the xref's for now. There's no guarantee that there'll be API docs by GA.
- Any text/tabs that mentions UWP should be changed to Windows now.
There's also some specific comments inline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davidbritch here is an example of the porting. Please correct anything you see wrong. This is going into the working branch, so ignore the build errors.