-
Couldn't load subscription status.
- Fork 236
Create comprehensive SafeAreaEdges documentation for .NET 10 #3058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Learn Build status updates of commit f1cc7d7: ✅ Validation status: passedFor more details, please refer to the build report. |
Co-authored-by: PureWeen <[email protected]>
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 7b9ee55: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Co-authored-by: PureWeen <[email protected]>
|
Learn Build status updates of commit 7b9ee55: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Co-authored-by: PureWeen <[email protected]>
|
Learn Build status updates of commit 5338905: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
1 similar comment
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit ad7ddb4: ✅ Validation status: passed
For more details, please refer to the build report. |
docs/user-interface/safe-area.md
Outdated
| ```csharp | ||
| var page = new ContentPage | ||
| { | ||
| SafeAreaEdges = SafeAreaRegions.None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit ad7ddb4. Changed SafeAreaRegions.None to SafeAreaEdges.None and updated all xrefs and enum documentation to use the correct SafeAreaEdges type throughout.
docs/user-interface/safe-area.md
Outdated
| - The `SoftInput` region includes the soft keyboard | ||
| - Behavior can vary based on edge-to-edge display settings and Android version | ||
|
|
||
| ### Windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot this API doesn't do anything on Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed Windows section in commit dee0080.
docs/user-interface/safe-area.md
Outdated
| - The `SoftInput` region includes the on-screen keyboard when visible | ||
| - Safe areas are generally less prominent but still respected | ||
|
|
||
| ## Reading safe area insets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot remove this section about reading safe area insets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the "Reading safe area insets" section in commit dee0080.
docs/user-interface/safe-area.md
Outdated
| **New approach (.NET 10+):** | ||
|
|
||
| ```xaml | ||
| <ContentPage SafeAreaEdges="All"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot this should be "Container" not call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed from "All" to "Container" in the migration example in commit dee0080.
Co-authored-by: PureWeen <[email protected]>
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit dee0080: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit dee0080: ✅ Validation status: passed
For more details, please refer to the build report. |
…ction, fix migration example Co-authored-by: PureWeen <[email protected]>
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 69a6cf8: ✅ Validation status: passed
For more details, please refer to the build report. |
docs/user-interface/safe-area.md
Outdated
|
|
||
| ```xaml | ||
| <ContentPage SafeAreaEdges="None"> | ||
| <Grid> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot make a note here that by default "Grid" will be set to "Container" so in order for this to go edge to edge you need to set the "Grid" to "Container"
By default ContentPage will already be set to none
All controls deriving from "Layout" will be set to "Container" by default
"ContentView" and "Border" (and any controls deriving from ContentView) will be set to "None" by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added default value documentation in commit 69a6cf8. The documentation now includes:
- A NOTE section explaining default values (ContentPage defaults to None, Layout/Grid defaults to Container, ContentView/Border defaults to None)
- Updated the Grid example to explicitly set SafeAreaEdges="None" for edge-to-edge content
- Added an explanatory note about why Grid needs explicit setting
Co-authored-by: PureWeen <[email protected]>
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 216adbb: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 216adbb: ✅ Validation status: passed
For more details, please refer to the build report. |
SafeAreaEdges Documentation Plan
Summary
Comprehensive SafeAreaEdges documentation for .NET MAUI 10 with all feedback addressed, including default value documentation and updated examples.
Original prompt
Fixes #3057
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.