Skip to content

Remove CAS attributes from snippets #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 10, 2022
Merged

Remove CAS attributes from snippets #1370

merged 8 commits into from
May 10, 2022

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented May 4, 2022

@gewarren
Copy link
Contributor Author

gewarren commented May 4, 2022

Oops, nevermind!

@gewarren gewarren closed this May 4, 2022
@gewarren
Copy link
Contributor Author

gewarren commented May 5, 2022

Oops, closed the wrong PR.

@gewarren gewarren reopened this May 5, 2022
@gewarren
Copy link
Contributor Author

gewarren commented May 5, 2022

This is good to go. The remaining snippets 5000 errors are either for 2 C++ snippets (which I have no idea how to add a project file for), or are false positives (I believe this is a bug in snippets 5000).

dotnet-desktop-guide/samples/snippets/cpp/VS_Snippets_Winforms/System.Windows.Forms.KeyboardInputForm/cpp/form1.cpp
dotnet-desktop-guide/samples/snippets/cpp/VS_Snippets_Winforms/System.Windows.Forms.WebBrowser/CPP/form1.cpp
dotnet-desktop-guide/samples/snippets/csharp/VS_Snippets_Wpf/InvokePatternApp/CSharp/snippets.5000.json
dotnet-desktop-guide/samples/snippets/visualbasic/VS_Snippets_Wpf/InvokePatternApp/VisualBasic/My Project/Application.Designer.vb
dotnet-desktop-guide/samples/snippets/visualbasic/VS_Snippets_Wpf/InvokePatternApp/VisualBasic/My Project/Resources.Designer.vb
dotnet-desktop-guide/samples/snippets/visualbasic/VS_Snippets_Wpf/InvokePatternApp/VisualBasic/My Project/Settings.Designer.vb
dotnet-desktop-guide/samples/snippets/visualbasic/VS_Snippets_Wpf/InvokePatternApp/VisualBasic/snippets.5000.json

@adegeo
Copy link
Contributor

adegeo commented May 5, 2022

@gewarren One of the errors is correct. It seems that there is a file copy/paste error that's been there forever. The /InvokePatternApp/VisualBasic/My Project/ folder can be deleted. It's a duplicate of the /InvokePatternApp/VisualBasic/InvokePatternClient/My Project/ folder.

There may be a flaw in the snippets system, but it may be an artifact from having two snippet.5000.json files. The /csharp/VS_Snippets_Wpf/InvokePatternApp/CSharp/snippets.5000.json file is in the same folder as the SLN, which is good. However, a child folder also has one. I don't know if there is a conflict because of this, but I would delete the snippets file in the child folder since it should be covered by the SLN one. The same goes for the visualbasic flavor of this folder path.

adegeo
adegeo requested changes May 9, 2022
View reviewed changes
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I meant to request changes :D

@gewarren gewarren requested a review from adegeo May 9, 2022 18:16
@gewarren gewarren requested a review from adegeo May 9, 2022 19:29
@gewarren
Copy link
Contributor Author

gewarren commented May 9, 2022

Thanks for the help! Looks like we're down to just the two C++ files now.

@adegeo adegeo merged commit 3140f15 into dotnet:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adegeo adegeo Awaiting requested review from adegeo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove CAS code in snippets

2 participants

@gewarren @adegeo