-
Notifications
You must be signed in to change notification settings - Fork 383
Bump Microsoft.Diagnostics.Tracing.TraceEvent to 3.1.28 and update dotnet-trace for NetTrace v6 support #5630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: mdh1418 <[email protected]>
|
@copilot #5610 requires changes to |
Update dotnet-trace convert and report to use ThreadTimeStackComputer instead of SampleProfilerThreadTimeComputer to handle thread time samples in NetTrace v6 format from collect-linux. Also update System.Text.Json, System.Collections.Immutable, System.Reflection.Metadata, and System.Text.Encodings.Web to 9.0.8 to satisfy TraceEvent 3.1.28 dependencies. Co-authored-by: mdh1418 <[email protected]>
Updated Also updated dependency versions (System.Text.Json, System.Collections.Immutable, System.Reflection.Metadata, System.Text.Encodings.Web) to 9.0.8 to satisfy TraceEvent 3.1.28 requirements. Changes in commit c1a67c9. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot Lets hold off on updating the PR for now, and lets just iterate on the files, check the changes without pushing commits. Can we do that? |
Fixes #5610
Updates TraceEvent package to enable NetTrace v6 format with thread time samples and updates
dotnet-trace convertanddotnet-trace reportcommands to handle .nettrace files generated bydotnet-trace collect-linux.Changes
MicrosoftDiagnosticsTracingTraceEventVersionineng/Versions.props:3.1.23→3.1.28dotnet-trace convertto useThreadTimeStackComputerinstead ofSampleProfilerThreadTimeComputerdotnet-trace reportto useThreadTimeStackComputerinstead ofSampleProfilerThreadTimeComputerSystem.Text.Json:8.0.5→9.0.8System.Collections.Immutable:8.0.0→9.0.8System.Reflection.Metadata:8.0.0→9.0.8System.Text.Encodings.Web:8.0.0→9.0.8What this enables
NetTrace v6 adds:
dotnet-trace collect-linux)The
ThreadTimeStackComputerclass handles traces with thread time samples that don't have Microsoft-DotNETCore-SampleProfiler events, which is the case for .nettrace files generated bydotnet-trace collect-linux.Affected components
dotnet-trace convertanddotnet-trace reportcommands (now support collect-linux traces)dotnet-counters,dotnet-gcdump,dotnet-stack,dotnet-dsrouter, and EventPipe monitoring librariesSee NetTrace v6 format spec for technical details.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.