Minor tweaks to #line directive and associated attributes #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added missing `PP_` prefix to two grammar rule references. 1. Added imp-def statement re max line number. The MS compiler accepts up to 2147483647, but for values greater than 16707565 it gives the following warning, "CS1687: Source file has exceeded the limit of 16,707,565 lines representable in the PDB, debug information will be incorrect." Any number greater than 16707565 is ignored, and numbering continues from the previous directive (if any). 1. Moved a md code fragment fence.
Clarified the behavior when multiple attributes are used on the same parameter.
jskeet
reviewed
Mar 22, 2023
BillWagner
approved these changes
Mar 22, 2023
jskeet
approved these changes
Mar 23, 2023
|
FYI, Re the Imp-Def list numbering, all items in the other 3 numbered list in that annex had number 1, but for some unknown reason, this list's items were numbered 1, 2, 3, ..., so when I added a new 2nd item, the web-based editor simply gave it the number 2! C'est la vie! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bill, the only normative change is the addition of the implementation-defined statement w.r.t the max value permitted for a line number. Prior to this edit, that was (implicitly) unspecified; now there is a requirement for an implementation to document it, which the current implementation does.