Skip to content

Conversation

jnm2
Copy link
Contributor

@jnm2 jnm2 commented Aug 27, 2025

Spotted one, then decided to walk through with a spell checker.

Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos all look fine - I don't know enough about the files under v6 and v7 to be able to comment on those. @Nigel-Ecma is there anything else we need to do for those?

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. I'd also like @Nigel-Ecma to take a look for the grammar validation.

Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@jskeet & @BillWagner – this PR has fixed a typo in the grammar, this changes the expected parse for a couple of samples – these files are usually machine generated but it looks like they've been hadn't edited, this is fine for csharpstandard but will need to be ported over to antler-testing.

@jnm2 – I'll port over to antler-testing in the next version of that repo, I don't think we need a version just for this typo. Next version is likely to be for PR#681.

@jnm2 jnm2 merged commit ec7a9ad into draft-v8 Sep 3, 2025
9 checks passed
@jnm2 jnm2 deleted the jnm2/typos branch September 3, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants