Skip to content

Remove (s) in favor of just s #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2025
Merged

Remove (s) in favor of just s #1292

merged 2 commits into from
Apr 11, 2025

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Mar 19, 2025

Fixes #1274

@jskeet jskeet added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Mar 19, 2025
jskeet
jskeet commented Mar 19, 2025
View reviewed changes
BillWagner
BillWagner approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @jskeet

I'm fine with the changes as you've proposed them.

Nigel-Ecma
Nigel-Ecma previously requested changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t see the need to remove the (s)’s – I use it in my own writing when it feels right – but will go with the consensus on this (and try to remember to not add any going forward).

One fix suggested.

@jskeet jskeet requested a review from Nigel-Ecma April 11, 2025 09:14
@jskeet
Copy link
Contributor Author

jskeet commented Apr 11, 2025

Merging this now, as I addressed Nigel's request.

@jskeet jskeet merged commit ba0673e into dotnet:draft-v8 Apr 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@RexJaeschke RexJaeschke RexJaeschke approved these changes

@gafter gafter Awaiting requested review from gafter

@ericlippert ericlippert Awaiting requested review from ericlippert

@Nigel-Ecma Nigel-Ecma Awaiting requested review from Nigel-Ecma

Assignees
No one assigned
Labels
meeting: discuss This issue should be discussed at the next TC49-TG2 meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can we avoid using (s) for things that can be multiple?
4 participants
@jskeet @BillWagner @Nigel-Ecma @RexJaeschke