Xml doc bugfixes #1004
Merged
Xml doc bugfixes #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#771 Add instances where the `<` and `>` characters are replaced by `{` and `}` in the string IDs.
Fixes dotnet#772 Single dimension arrays are encoded as "[]" rather than "[0]".
Fixes dotnet#915 In the example in D5, add the "name=" attribute on all param tags.
BillWagner
added
the
meeting: discuss
jskeet
approved these changes
Nov 22, 2023
I thought about removing the `<c>` tags in my previous commit, but I was waiting for other opinions, and wanted to verify that there was at least one tag like that still in the example.
|
Now I wonder how the name of a type is formatted in these if it involves an |
|
The extern alias thing is a bit related to dotnet/docfx#2620 |
jskeet
reviewed
Nov 29, 2023
Co-authored-by: Jon Skeet <[email protected]>
MadsTorgersen
approved these changes
Nov 29, 2023
Nigel-Ecma
approved these changes
Nov 29, 2023
gafter
approved these changes
Nov 29, 2023
Meeting note: We're not sure either. Please feel free to experiment and either raise a PR or an issue with your findings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes three issues:
Fixes #771. The string IDs for methods that are explicit implementations of members of generic interfaces have the
<and>characters replaced with{and}.Fixes #772: single dimension arrays don't specify the lower bound in their string ids. Instead of
[0]its[].Fixes #915: The example didn't include the "name=" attributes on parameters.
The fixes are in three distinct commits to make it easier to review.