Support the app directives used in file-based programs #337
Conversation
JoeRobich
force-pushed
the
dev/jorobich/app-directives
branch
from
a655f40 to
8398aed
Compare
| '1': { name: punctuation.separator.colon.cs } | ||
| end: (?=$) | ||
| patterns: | ||
| - include: '#preprocessor-app-directive-package' |
There was a problem hiding this comment.
I'm torn between telling you to go add sdk support as well (and ask @jjonescz what other directives are supported), or just saying that we shouldn't do any of these and just do the generic version. Your call.
There was a problem hiding this comment.
I'm not sure what you mean, sdk seems to be supported here? I think you got all the directives we currently support.
There was a problem hiding this comment.
Apparently my eyes glazed over the last section... that's what happens when you review PRs at 10:30 PM I guess.
| Token.Identifier.PreprocessorSymbol("Foo"), | ||
| Token.Punctuation.Dot, | ||
| Token.Identifier.PreprocessorSymbol("Goo"), |
There was a problem hiding this comment.
Was there a specific reason to make the dots separate tokens? It doesn't look like this is how preprocessor symbols are handled, for example:
wait.. no. maybe it is. It's just in my theme I have to zoom in to be able to distinguish the color of the dot.
There was a problem hiding this comment.
We certainly don't have to, but many packages are dot separated and I thought it might be a good visual signal.
Uh oh!
There was an error while loading. Please reload this page.