This repository was archived by the owner on Jan 23, 2023. It is now read-only.
System.Numeric.Tests tests now have unique inputs #40564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix add, subtract and multiplication tests now have unique inputs
|
|
Member
tannergooding
approved these changes
Aug 26, 2019
Member
|
Thanks! Removing unique test data in the repo is on our backlog as we need it for some upcoming infra changes as well. Great that you are contributing to that effort 👍 |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Matrix add, subtract and multiplication tests now have unique inputs Commit migrated from dotnet/corefx@cadc61e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matrix add, subtract and multiplication tests now have unique inputs. This would prevent regression due to the values for certain tests being the same between the LHS and RHS inputs (such as the one introduced in #31779).
This resolves #39890