This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Implement initThisClass for generic types in ReadyToRun #7842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@dotnet/jit-contrib PTAL |
pgavlin
approved these changes
Oct 27, 2016
| if (opts.IsReadyToRun() && eeGetEEInfo()->targetAbi == CORINFO_CORERT_ABI) | ||
| { | ||
| CORINFO_RESOLVED_TOKEN resolvedToken; | ||
| ZeroMemory(&resolvedToken, sizeof(resolvedToken)); |
There was a problem hiding this comment.
IIRC we prefer memset in the JIT to ZeroMemory.
There was a problem hiding this comment.
CORINFO_RESOLVED_TOKEN resolvedToken { }; 😁
Member
Author
There was a problem hiding this comment.
I copypasted this from the nongeneric ReadyToRun path. I will fix it in both in a separate pull request. I really want to merge this before the "#7837 Introduce new CORJIT_FLAGS type" pull request gets merged because I need this to unblock myself on CoreRT and I would rather not deal with updating JitInterface on CoreRT right now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only implementing the RyuJIT portion for CoreRT purposes (CoreRT side at dotnet/corert#2085).
I can file an issue to add support for this in CoreCLR if there's interest. On CoreCLR this is currently a disqualification from ReadyToRun and causes fallback to JITting.