This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Delete setup_coredis_tools from runtest.py.
#23495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
cc @dotnet/jit-contrib |
sandreenko
added
os-linux
Author
|
@dotnet-bot test Ubuntu x64 Checked r2r_gcstress15 Queues Ubuntu x64 Checked R2R gcstress15 Build and Test |
jashook
approved these changes
Mar 27, 2019
BruceForstall
approved these changes
Mar 27, 2019
sandreenko
force-pushed
the
updateRuntestsPy
branch
from
af8a505 to
e47ee50
Compare
Author
|
@dotnet-bot test Ubuntu x64 Checked r2r_gcstress15 |
1 similar comment
Author
|
@dotnet-bot test Ubuntu x64 Checked r2r_gcstress15 |
sandreenko
force-pushed
the
updateRuntestsPy
branch
from
bf0e3c4 to
99a21a2
Compare
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Delete `setup_coredis_tools` from runtest.py. * delete dead `setup_coredis_tools` . Commit migrated from dotnet/coreclr@3483c6e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-test.cmdalways callssetup-stress-dependencies:coreclr/build-test.cmd
Line 179 in 6a48f05
I have updated
build-test.shto do the same for ADO runs (where we do not useruntest.py) in #23435:coreclr/build-test.sh
Lines 158 to 159 in 6a48f05
So now we do not need to repeat this in python script, moreover it did not work right when
GCStresswas set not to0xCbut to0xF,0xEor0xD.Closes #23477.