Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@sdmaclea
Copy link

Verify EntryPointFilter solves logging problem with native host swallowing exceptions

WindowsEventLog only look at new entries
WindowsEventLog remove time check

Add mechanism to corhost to emulate host swallowing all exceptions

@sdmaclea
Copy link
Author

sdmaclea commented Mar 11, 2019

This is the test which was originally part of #23054. It has been updated to use named arguments for literals as requested by @AaronRobinsonMSFT

It adds the environment variable which was requested by @davidfowl and originally requested to be removed by @vitek-karas

It is adding a coreclr EX_TRY/EX_CATCH_HR for all exceptions. This is not a great simulation of ASP.NET's current solution as noted by @jkotas. Long term it might be the best to add this catch feature for ASP.NET for a few reasons:

  • We are able to catch the best possible way.
  • If we catch it we can test it, so the test and the code to catch are logically located in the same repo.

It does not include a custom host, nor is it using the new hosting API which @elinor-fung will be adding.

@sdmaclea sdmaclea changed the title Extend WindowsEventLog test Extend WindowsEventLog test for EntryPointFilter Mar 11, 2019
@sdmaclea
Copy link
Author

test Ubuntu x64 Formatting
test Ubuntu x64 Checked Innerloop Build and Test

@jkotalik
Copy link

What's the status on this PR? We need the environment variable option to set UseEntrypointFilter.

@sdmaclea
Copy link
Author

Rebased to retrigger jobs

Verify EntryPointFilter solves logging problem with native host swallowing exceptions

WindowsEventLog only look at new entries
WindowsEventLog remove time check

Add mechanism to corhost to emulate host swallowing all exceptions
@sdmaclea
Copy link
Author

test Ubuntu arm Cross Release crossgen_comparison Build and Test
test Ubuntu arm Cross Checked crossgen_comparison Build and Test

@sdmaclea
Copy link
Author

Merging as this is blocking dotnet/aspnetcore#8518

@sdmaclea sdmaclea merged commit 66c05ce into dotnet:master Mar 27, 2019
@sdmaclea sdmaclea deleted the EntryPointTest branch June 10, 2021 00:29
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Extend WindowsEventLog test

Verify EntryPointFilter solves logging problem with native host swallowing exceptions

WindowsEventLog only look at new entries
WindowsEventLog remove time check

Add mechanism to corhost to emulate host swallowing all exceptions

* PR feedback


Commit migrated from dotnet/coreclr@66c05ce
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants