-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Extend WindowsEventLog test for EntryPointFilter #23178
Conversation
|
This is the test which was originally part of #23054. It has been updated to use named arguments for literals as requested by @AaronRobinsonMSFT It adds the environment variable which was requested by @davidfowl and originally requested to be removed by @vitek-karas It is adding a coreclr EX_TRY/EX_CATCH_HR for all exceptions. This is not a great simulation of ASP.NET's current solution as noted by @jkotas. Long term it might be the best to add this catch feature for ASP.NET for a few reasons:
It does not include a custom host, nor is it using the new hosting API which @elinor-fung will be adding. |
|
test Ubuntu x64 Formatting |
|
What's the status on this PR? We need the environment variable option to set UseEntrypointFilter. |
aec8a74 to
b4e186b
Compare
|
Rebased to retrigger jobs |
Verify EntryPointFilter solves logging problem with native host swallowing exceptions WindowsEventLog only look at new entries WindowsEventLog remove time check Add mechanism to corhost to emulate host swallowing all exceptions
b4e186b to
f809d0c
Compare
|
test Ubuntu arm Cross Release crossgen_comparison Build and Test |
|
Merging as this is blocking dotnet/aspnetcore#8518 |
* Extend WindowsEventLog test Verify EntryPointFilter solves logging problem with native host swallowing exceptions WindowsEventLog only look at new entries WindowsEventLog remove time check Add mechanism to corhost to emulate host swallowing all exceptions * PR feedback Commit migrated from dotnet/coreclr@66c05ce
Verify EntryPointFilter solves logging problem with native host swallowing exceptions
WindowsEventLog only look at new entries
WindowsEventLog remove time check
Add mechanism to corhost to emulate host swallowing all exceptions