Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

JIT: port fix to spill the eval stack when storing to a pinned local to release/2.0 #15744

Merged
merged 1 commit into from
Feb 26, 2018
Merged

JIT: port fix to spill the eval stack when storing to a pinned local to release/2.0 #15744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/jit/importer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10220,13 +10220,14 @@ void Compiler::impImportBlockCode(BasicBlock* block)

op2 = gtNewLclvNode(lclNum, lclTyp, opcodeOffs + sz + 1);

/* If the local is aliased, we need to spill calls and
/* If the local is aliased or pinned, we need to spill calls and
indirections from the stack. */

if ((lvaTable[lclNum].lvAddrExposed || lvaTable[lclNum].lvHasLdAddrOp) &&
verCurrentState.esStackDepth > 0)
if ((lvaTable[lclNum].lvAddrExposed || lvaTable[lclNum].lvHasLdAddrOp || lvaTable[lclNum].lvPinned) &&
(verCurrentState.esStackDepth > 0))
{
impSpillSideEffects(false, (unsigned)CHECK_SPILL_ALL DEBUGARG("Local could be aliased"));
impSpillSideEffects(false,
(unsigned)CHECK_SPILL_ALL DEBUGARG("Local could be aliased or is pinned"));
}

/* Spill any refs to the local from the stack */
Expand Down