api diff between preview 3 and preview 4 #6265
Conversation
|
|
||
| ``` diff | ||
| namespace Microsoft.AspNetCore.Builder { | ||
| + public sealed class Configuration : IConfiguration, IConfigurationBuilder, IConfigurationRoot { |
There was a problem hiding this comment.
@halter73 could you verify the minimal-host changes?
| # System.Numerics | ||
|
|
||
| ``` diff | ||
| namespace System.Numerics { |
There was a problem hiding this comment.
System.Numerics changes LGTM.
CC. @pgovind
|
|
||
| ``` diff | ||
| namespace System { | ||
| - public readonly struct Byte : IComparable, IComparable<byte>, IConvertible, IEquatable<byte>, IFormattable |
There was a problem hiding this comment.
ISpanFormattable addition to core numeric types LGTM.
CC. @pgovind, @stephentoub
|
|
||
| ``` diff | ||
| +namespace Microsoft.AspNetCore.HttpLogging { | ||
| + public enum HttpLoggingFields : long { |
There was a problem hiding this comment.
FWIW the generated diffs here end up with the calculated values - I was confused as to why this wasn't done by bitwise-OR'ing fields together, and it turns out that it is done this way, but you can only see it in the source source.dot.net .
It would be good to have the diffs generated, if possible, with the broken-out values to make it easier to understand rather than the final bitwise calculation
cc @tannergooding - discussed with him on the C# Discord
There was a problem hiding this comment.
Notably the diff here is also missing the [Flags] attribute that is in the source/ref assembly
There was a problem hiding this comment.
i will take a look if we can fix this issue in the tooling.
|
Date/Time/Time zones included in System namespace changes LGTM. |
| # Microsoft.AspNetCore.HttpLogging | ||
|
|
||
| ``` diff | ||
| +namespace Microsoft.AspNetCore.HttpLogging { |
|
hello everyone, can everyone validate their area changes by end of the day. |
| @@ -0,0 +1,142 @@ | |||
| # System.Text.Json.Node | |||
...s/6.0/preview/api-diff/preview4/.Net/6.0-preview4_System.Text.Json.Serialization.Metadata.md
Show resolved
Hide resolved
| ``` diff | ||
| namespace System.Threading { | ||
| public class CancellationTokenSource : IDisposable { | ||
| + public bool TryReset(); |
| # System.Numerics | ||
|
|
||
| ``` diff | ||
| namespace System.Numerics { |
12 participants
cc @adamsitnik @carlossanlop @jozkee @eiriktsarpalis @layomia @buyaa-n @joperezr @krwq @kouvel @pgovind @tannergooding @steveharter @tarekgh @dotnet/ncl
@stephentoub @ericstj @danmoseley
cc @pranavkm @Tratcher @Pilchie @davidfowl @dougbu @richlander