This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix issue with apphost deps resolver #3922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I really wish we would invest in tests for this functionality. |
eerhardt
approved these changes
Mar 28, 2018
Author
Yes. It is mostly timing. It's probably 2 days or so of "throw-away" test infrastructure work if we want to do that now, which would throw away once tooling supports this mode. Also I believe this particular issue also shows a lack of coverage in the existing self-contained tests. |
steveharter
added a commit
to steveharter/core-setup
that referenced
this pull request
Mar 28, 2018
steveharter
added a commit
that referenced
this pull request
Mar 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue introduced by #3888
The app root was getting set to the incorrect directory, causing deps resolution to fail to load additional assemblies.
I added this scenario to the test issue at https://github.com/dotnet/core-setup/issues/3910
cc @wli3