Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@janvorli
Copy link
Member

@janvorli janvorli commented Nov 7, 2017

This is a leftover from the Alpine enabling changes that I've forgotten
to make after corefx and coreclr official builds were enabled.

This is a leftover from the Alpine enabling changes that I've forgotten
to make after corefx and coreclr official builds were enabled.
@janvorli janvorli self-assigned this Nov 7, 2017
@janvorli janvorli requested a review from eerhardt November 7, 2017 03:15
@janvorli
Copy link
Member Author

janvorli commented Nov 7, 2017

cc: @MichaelSimons

@janvorli
Copy link
Member Author

janvorli commented Nov 7, 2017

@eerhardt I have removed this from my original change that enabled Alpine support in core-setup based on your feedback, but forgotten to add it after the official builds of coreclr / corefx were out.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I verified we have corefx and coreclr builds for alpine.3.6 for the current versions we are on. So this should work.

@eerhardt eerhardt merged commit 5e5b627 into dotnet:master Nov 7, 2017
@eerhardt
Copy link
Member

eerhardt commented Nov 7, 2017

@janvorli - are we enabling Jenkins legs for alpine and rhel6?

@janvorli
Copy link
Member Author

janvorli commented Nov 7, 2017

@eerhardt I've enabled RHEL 6 in corefx only so far (optionally). I've discussed it with @mmitche some time ago and the recommendation was to wait with coreclr / core-setup until the ci moves to the new way of using pipelines for CI build.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants