UriHelper use Ordinal string.IndexOf #9537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
requested review from
Tratcher,
analogrelay and
jkotalik
as code owners
stephentoub
approved these changes
Apr 19, 2019
JamesNK
approved these changes
Apr 19, 2019
Tratcher
approved these changes
Apr 19, 2019
filipnavara
approved these changes
Apr 19, 2019
GrabYourPitchforks
approved these changes
Apr 19, 2019
Member
|
Also, enable Roslyn Code Analyzers over the source. It would have caught this. :) |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was wondering why the Proxy scenario was hitting Globablization #9404 (comment)
string.IndexOf(string)is current culture by default; unlike most of the other string apis which are Ordinal; so switch to using Ordinal IndexOf to find things./cc @GrabYourPitchforks as I know you love the inconsistency of these apis 😉