Skip to content

Conversation

@javiercn
Copy link
Member

No description provided.

@javiercn javiercn requested a review from dougbu as a code owner March 15, 2019 18:42
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update KillProcesses.sh too

Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still curious: Why is _kill java.exe or a couple of similar commands insufficient? And, why isn't it useful to kill Java processes on non-Windows machines i.e. in KillProcesses.sh (that only kills dotnet)?

@Eilon Eilon merged commit adf978a into master Mar 15, 2019
@Eilon
Copy link
Contributor

Eilon commented Mar 15, 2019

Force merged.

@Eilon
Copy link
Contributor

Eilon commented Mar 15, 2019

Thanx @javiercn !

@natemcmaster natemcmaster deleted the javiercn/kill-java-after-run-on-ci branch May 3, 2019 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants