Port Handle EOF HResult from async callback to 2.2 #6483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @muratg |
jkotalik
approved these changes
Jan 8, 2019
jamshedd
added
Servicing-approved
Contributor
|
Please wait until https://github.com/aspnet/AspNetCore-Internal/issues/1610 is resolved before merging. |
Member
|
Approved for 2.2.2. |
pakrym
force-pushed
the
pakrym/eof-hr-2-2
branch
from
fb2c641 to
fbe72d1
Compare
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(VersionPrefix)' == '2.2.2' "> | ||
| <PackagesInPatch> | ||
| @aspnet/signalr; |
Contributor
There was a problem hiding this comment.
FYI @BrennanConroy
Intentional removal? We need this if we want to patch NPM packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6415
Description
When using in-proc mode with ANCM, POST requests can randomly result in
contex.Request.Body.ReadAsyncthrowing because successful error code is not handled correctly in all places.Regression?
Regression from out-of-process hosting model.
Risk
Very Low. Handling same error code we did before but in more centralized fashion.