Add System.Security.Cryptography.Pkcs to targeting pack #64172
Merged
+1
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds System.Security.Cryptography.Pkcs to the ASP.NET Core targeting pack to resolve package pruning issues. The library was previously excluded due to historical reference resolution quirks, but this exclusion is no longer necessary.
Key Changes:
- Removed the MSBuild target that explicitly excluded
System.Security.Cryptography.Pkcsfrom the reference pack - Added
System.Security.Cryptography.Pkcsto the test data to validate its inclusion
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Framework/App.Ref/src/Microsoft.AspNetCore.App.Ref.sfxproj | Removed the _RemovePkcsReference MSBuild target that was excluding the Pkcs library |
| src/Framework/test/TestData.cs | Added System.Security.Cryptography.Pkcs to the expected assemblies list for test validation |
github-actions
bot
added
the
area-infrastructure
nkolev92
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #64125. This library wasn't in the targeting pack historically due to some quirks of reference resolution, but AFAIK there's not a strong reason to maintain that behavior. Adding it to the transport pack will fix some issues w/ package pruning.