-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Pages that are re-executed should allow interactivity #63964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables interactivity for re-executed page components to maintain consistency with pages rendered through NavigationManager.NotFound(). Previously, re-executed pages were forced to use SSR mode, creating an inconsistency in behavior.
Key Changes
- Removed the
_isReExecutedcondition that forced SSR mode for re-executed pages - Updated the test to verify interactivity functionality on re-executed pages
- Enhanced the re-executed page component with interactive counter functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ReexecutedPage.razor | Added interactive server render mode and counter functionality to test interactivity |
| InteractivityTest.cs | Converted test to fact and added interactivity verification |
| EndpointHtmlRenderer.Prerendering.cs | Removed re-execution condition that forced SSR mode |
maraf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/aspnetcore/actions/runs/18385401724 |
Do not skip Render Mode boundary for re-executions
Re-executed page components should have configurable render mode because typically re-executed page is used in the same places as page rendered by
NavigationManager.NotFound(). By allowing interactivity in the latter but not supporting it in the former case, we introduce inconsistency.Description
Fixes #63963