Fix two loads in QuickGrid with Virtualize #63616
Open
+54
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the QuickGrid component's data loading behavior when virtualization is enabled, preventing redundant data loads on initial render. The optimization introduces a flag to track the first refresh and allows the Virtualize component to handle the initial data loading itself.
Key changes:
- Added first-load tracking to prevent duplicate data loading
- Updated refresh logic to conditionally skip initial load for virtualized grids
- Improved performance by eliminating redundant initial data fetching
src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/QuickGrid.razor.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
ilonatommy
reviewed
Sep 11, 2025
| @@ -155,6 +155,8 @@ public partial class QuickGrid<TGridItem> : IAsyncDisposable | |||
| // If the QuickGrid is disposed while the JS module is being loaded, we need to avoid calling JS methods | |||
| private bool _wasDisposed; | |||
|
|
|||
| private bool _firstRefreshDataAsync = true; | |||
There was a problem hiding this comment.
"Added a _firstRefreshDataAsync flag to the QuickGrid class to track whether the initial data load has occurred."
Can we simplify it to _shouldSkipDataLoad? Or _shouldSkipDataRefresh.
Suggested change
| private bool _firstRefreshDataAsync = true; | |
| private bool _shouldSkipDataLoad = true; |
src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/QuickGrid.razor.cs
Outdated
Show resolved
Hide resolved
dariatiurina
force-pushed
the
55979-items-provider-virtualize
branch
from
f95786c to
bad1df2
Compare
javiercn
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two loads in QuickGrid with Virtualize
Description
This pull request introduces an optimization to the data loading logic for the
QuickGridcomponent, specifically when using virtualization. The main goal is to prevent redundant data loading on the initial render, improving performance and user experience.Virtualization data loading optimization:
_firstRefreshDataAsyncflag to theQuickGridclass to track whether the initial data load has occurred.RefreshDataCoreAsyncmethod to skip the data loading logic on the first render if virtualization is enabled, allowing theVirtualizecomponent to handle the initial data load itself.Fixes #55979