[release/10.0-preview5] NoWarn SIGN004 #62048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Temporarily suppresses the SIGN004 signing warning for R2R images in Preview5 builds pending a long-term fix in Arcade.
- Adds a NoWarn entry for SIGN004 in
Directory.Build.props - Includes a comment explaining the temporary nature of the suppression
mmitche
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SignTool mistakenly sees R2R images as 3rd-party, because they don't have a copyright string. Therefore we get an error about signing 3rd party libraries w/ 1st party signatures. NoWarn this for now in p5 - we're working on a better fix in Arcade for the long term.