Skip to content

Skip tests on internal queues too #59574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Skip tests on internal queues too #59574

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99ba38c
Skip tests on internal too
wtgodbe Dec 19, 2024
b50f4bb
StringComparison
wtgodbe Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Testing/src/xunit/SkipOnHelixAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ private bool ShouldSkip()
return true;
}

return Queues.ToLowerInvariant().Split(';').Contains(targetQueue);
// We have "QueueName" and "QueueName.Open" queues for internal and public builds
// If we want to skip the test in the public queue, we want to skip it in the internal queue, and vice versa
return Queues.ToLowerInvariant().Split(';').Any(q => q.Equals(targetQueue, StringComparison.Ordinal) || q.StartsWith(targetQueue, StringComparison.Ordinal) ||
targetQueue.StartsWith(q, StringComparison.Ordinal));
}

public static bool OnHelix() => HelixHelper.OnHelix();
Expand Down
Loading