Pass -sign and -publish switch to dotnet build only #59068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
ellahathaway
approved these changes
Nov 20, 2024
ViktorHofer
added a commit
that referenced
this pull request
Nov 20, 2024
This reverts commit 64e76be.
wtgodbe
pushed a commit
that referenced
this pull request
Nov 20, 2024
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/sdk#44855
As discussed offline with @wtgodbe, we need to be able to build the entire repository with a single invocation of eng/build.cmd. The problem is that with aspnetcore invoking the build twice in eng/build.ps1 the
-signand-publishflags get passed into both invocations and Arcade then fails to sign and publish the artifacts from the native build step.Instead only ever pass those flags to the dotnet build.