IBrowserFile FormDataConverter Mismatch between Name and FileName #56833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conversion in BrowserFileFromFormFile maps from IFormFile the Name property as if it was the FileName, so instead of [File.ext] the Name will have [Input.File]. This change will fix this conversion error so that the filename is correct.
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Thanks for your PR, @jlchavez. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
javiercn
reviewed
Jul 17, 2024
Member
javiercn
left a comment
javiercn
left a comment
There was a problem hiding this comment.
Looks good, but we should add a test.
javiercn
added
the
pr: pending author input
Contributor
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
dotnet-policy-service
bot
added
the
pending-ci-rerun
Contributor
dotnet-policy-service
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion in BrowserFileFromFormFile maps from IFormFile the Name property as if it was the FileName, so instead of [File.ext] the Name will have [Input.File].
This change will fix this conversion error so that the filename is correct.
IBrowserFile FormDataConverter Mismatch between Name and FileName
Fixes BrowserFileFromFormFile to get the correct Name for the uploaded file
Description
BrowserFileFromFormFile retrieves from IFileInput the property from Name and not from FileName, so just a minimal fix.
Fixes #56832