Update JDK #56210
Merged
Update JDK #56210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
wtgodbe
approved these changes
Jun 12, 2024
adityamandaleeka
approved these changes
Jun 12, 2024
|
I asked that in the Teams discussion as well. Should a jdk minor version update really cause aspnetcore's build to fail? I think the hardcoded version in global.json is a problem. |
|
Based on https://github.com/dotnet/arcade/blob/main/Documentation/NativeToolsOnMachine.md, we can change it to |
Probably not for minor/patch. But someone can do that in a follow up PR. No need to block PR builds longer than necessary for a minor cleanup. |
|
Failures unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.