Skip to content

Update to new interceptable location APIs #55285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2024
Merged

Update to new interceptable location APIs #55285

merged 2 commits into from
Apr 23, 2024

Conversation

@captainsafia
Copy link
Member

Addresses #55152

@ghost ghost added the area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc label Apr 22, 2024
@captainsafia
Copy link
Member Author

@dotnet/source-build-internal Any guidance on the source build issues here?

@MichaelSimons
Copy link
Member

I believe these two new prebuilts should be added to the SourceBuildPrebuiltBaseline as allowed prebuilts. These won't be prebuilts in the product source-build because the live Rolsyn version will get picked up because the dependency is declared in the Version.Details.xml file.

@captainsafia captainsafia marked this pull request as ready for review April 22, 2024 23:38
RikkiGibson
RikkiGibson reviewed Apr 23, 2024
View reviewed changes
src/Http/Http.Extensions/gen/StaticRouteHandlerModel/Endpoint.cs

public override bool Equals(object o) =>
o is Endpoint other && Location == other.Location && SignatureEquals(this, other);
o is Endpoint other && InterceptableLocation == other.InterceptableLocation && SignatureEquals(this, other);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we implemented operator == on these. That might be a bug on our side. I'll have to follow up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An explicit == implementation would be nice. I assume this does implement equality checks correctly though given that it does the correct things in our cache invalidation tests for incremental generators.

MichaelSimons
MichaelSimons approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source-Build change LGTM.

@captainsafia
Copy link
Member Author

@dotnet/aspnet-build Can I get help merging this? The macOS build is successful on AzDo but there appears to be an issue with the GH status check.

@captainsafia captainsafia merged commit 78cb980 into main Apr 23, 2024
@captainsafia captainsafia deleted the safia/interceptors-update branch April 23, 2024 16:49
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview4 milestone Apr 23, 2024
@wtgodbe wtgodbe mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@MichaelSimons MichaelSimons MichaelSimons approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees

No one assigned

Labels

area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-rdg

Projects

None yet

Milestone

9.0-preview4

Development

Successfully merging this pull request may close these issues.

3 participants

@captainsafia @MichaelSimons @RikkiGibson