Use the VMR commit hash in .version #54461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This puts the VMR's commit hash, provided by the VMR as the property DotNetGitCommitHash, in the .version file. Contributes to dotnet/source-build#3643
ghost
added
the
area-infrastructure
dotnet-policy-service
bot
added
the
community-contribution
wtgodbe
approved these changes
Mar 12, 2024
omajid
added a commit
to omajid/dotnet-aspnetcore
that referenced
this pull request
Mar 19, 2024
This reverts commit 818d0e3. Over at dotnet/installer#18941, we decied that we wanted to go in a different (and simpler!) direction. We will make sure `SourceRevisionId` is defined/used correctly everywhere.
wtgodbe
pushed a commit
that referenced
this pull request
Mar 19, 2024
This reverts commit 818d0e3. Over at dotnet/installer#18941, we decied that we wanted to go in a different (and simpler!) direction. We will make sure `SourceRevisionId` is defined/used correctly everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts the VMR's commit hash, provided by the VMR as the property DotNetGitCommitHash, in the .version file.
Contributes to dotnet/source-build#3643