Add unit test to confirm change token is disposed during #53827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razer hot reload.
ghost
added
the
src/Components/Endpoints/src/Builder/RazorComponentEndpointDataSource.cs
Outdated
Show resolved
Hide resolved
to create the wrapped disposable for this unit test.
MackinnonBuck
approved these changes
Feb 7, 2024
MackinnonBuck
added a commit
that referenced
this pull request
Feb 9, 2024
* Add unit test to confirm change token is disposed during razer hot reload. * Per Makinnon's feedback, switch to a callback model to create the wrapped disposable for this unit test. * Update src/Components/Endpoints/test/HotReloadServiceTests.cs --------- Co-authored-by: Mackinnon Buck <[email protected]>
10 tasks
wtgodbe
pushed a commit
that referenced
this pull request
Feb 12, 2024
* Resolve change token leak in Blazor hot reload (#53750) Fix of razor hotreload change token leak. This disposes the old change tokens after the ClearCache event or before overwriting. If something goes wrong and this isn't cleared before the next invocation of UpdateEndpoints on the razor data source, clear it and dispose of it then. * Add unit test to confirm change token is disposed during (#53827) * Add unit test to confirm change token is disposed during razer hot reload. * Per Makinnon's feedback, switch to a callback model to create the wrapped disposable for this unit test. * Update src/Components/Endpoints/test/HotReloadServiceTests.cs --------- Co-authored-by: Mackinnon Buck <[email protected]> --------- Co-authored-by: jacdavis <[email protected]>
onurmicoogullari
pushed a commit
to onurmicoogullari/aspnetcore
that referenced
this pull request
Feb 14, 2024
* Add unit test to confirm change token is disposed during razer hot reload. * Per Makinnon's feedback, switch to a callback model to create the wrapped disposable for this unit test. * Update src/Components/Endpoints/test/HotReloadServiceTests.cs --------- Co-authored-by: Mackinnon Buck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit test to confirm change token is disposed during razer hot reload.
During the unit test, the disposable change token is wrapped in an object that can
track and return dispose state. This is only used during this one unit test.