Fix closing SignalR Websocket connection on server close #53288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Jan 10, 2024
| transport = HttpTransportType.WebSockets; | ||
| connection = await GetOrCreateConnectionAsync(context, options); | ||
|
|
||
| if (connection is not null) |
There was a problem hiding this comment.
If you attempt to connect with a connection id query string param that doesn't exist on this server instance.
There was a problem hiding this comment.
This method name is bad then, GetOrCreateOrNot
There was a problem hiding this comment.
😆 this method name is >8 years old now.
|
This is great news, thank you @BrennanConroy! Is there a temporary workaround available to prevent a slow shutdown? |
davidfowl
reviewed
Jan 11, 2024
src/SignalR/common/Http.Connections/test/HttpConnectionDispatcherTests.cs
Outdated
Show resolved
Hide resolved
davidfowl
approved these changes
Jan 12, 2024
ghost
added this to the
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/7545049507 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53165
Regressed in f56c242#diff-1a6e4221ebf9343c0f831c3bddda91e203203f07d212575ad2f413ce3b3e2b34L177
We just never had a "server close" test.