Skip to content

Conversation

@javiercn
Copy link
Member

@javiercn javiercn commented Jan 9, 2024

As part of updating the container image we use for source build to include node, yarn projects have started to run on source build (which is not "yet" enabled for 8.0 builds).

This PR tries to disable this explicitly on the build script

@javiercn javiercn requested review from a team and wtgodbe as code owners January 9, 2024 08:15
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 9, 2024
@ghost ghost added this to the 8.0.x milestone Jan 9, 2024
@ghost
Copy link

ghost commented Jan 9, 2024

Hi @javiercn. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@ghost
Copy link

ghost commented Jan 9, 2024

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@javiercn javiercn added the tell-mode Indicates a PR which is being merged during tell-mode label Jan 9, 2024
@SteveSandersonMS SteveSandersonMS self-requested a review January 9, 2024 11:14
Copy link
Contributor

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @javiercn !

@mkArtakMSFT mkArtakMSFT merged commit 2a7ea53 into release/8.0 Jan 9, 2024
@mkArtakMSFT mkArtakMSFT deleted the javiercn/disable-yarn-release-80-source-build branch January 9, 2024 16:30
@ghost ghost modified the milestones: 8.0.x, 8.0.2 Jan 9, 2024
@wtgodbe
Copy link
Member

wtgodbe commented Jan 9, 2024

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Started backporting to release/7.0: https://github.com/dotnet/aspnetcore/actions/runs/7466867291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants