Added a null check in ResolveHasInvalidAntiforgeryValidationFeature() #53208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johatuni
requested review from
BrennanConroy,
captainsafia and
halter73
as code owners
ghost
added
area-networking
|
Thanks for your PR, @johatuni. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
2 tasks
captainsafia
reviewed
Jan 8, 2024
Contributor
Author
|
@dotnet-policy-service agree company="Unimicro" |
…n ReadFormAsync() to guard against _request equal to null
davidfowl
reviewed
Jan 10, 2024
ghost
added
the
pending-ci-rerun
amcasey
reviewed
Jan 17, 2024
…e will now be set to null if Form is set to null.
wtgodbe
removed
the
pending-ci-rerun
dotnet-policy-service
bot
added
the
area-infrastructure
wtgodbe
removed
the
area-infrastructure
dotnet-policy-service
bot
added
the
pending-ci-rerun
amcasey
approved these changes
Feb 21, 2024
| return false; | ||
| } | ||
|
|
||
| var contentType = ContentType; |
Member
There was a problem hiding this comment.
Personally, I think it would be clearer to check whether contentType is null (rather than testing _request) - the fact that a null _request yields a null ContentType seems like an implementation detail.
Co-authored-by: Andrew Casey <[email protected]>
Co-authored-by: Andrew Casey <[email protected]>
Member
|
Well, those CI failures are clearly unrelated... Let's try a re-run. |
Member
|
/azp run |
dotnet-policy-service
bot
removed
the
pending-ci-rerun
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
#54177 should unblock CI when it merges. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
dotnet-policy-service
bot
added
the
pending-ci-rerun
Member
|
/azp run |
dotnet-policy-service
bot
removed
the
pending-ci-rerun
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a null check in ResolveHasInvalidAntiforgeryValidationFeature()
Summary of the changes (Less than 80 chars)
Description
Added a null check for the _request field since this will be null when type is constructed with the constructor taking a IFormCollection parameter.
Fixes #53099